feat(PassManager): handle IR printing in PassManager
#486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the submission, it is much appreciated! I am going to close this in favor of #494 as that PR is further along, and implements more support for configuring IR printing via the driver, etc., but I don't want to discourage you from future contributions! Please leave a comment on issues you want to tackle in the future, and we'll make sure nobody is doing conflicting work (or let you know if it is already being worked on). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #455.
Wires up
IRPrintingConfigwithPassManagerto implement IR printing functionality viaPassManager. Currently still a draft. It would be great to get some initial feedback whether the approach here makes sense.Should the
Printpass stay or be removed oncePassManagertakes care of IR printing?